gh-53509: Move _PyObject_ASSERT() to the internal C API #139872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
a team,
AA-Turner,
emmatyping and
erlend-aasland
as code owners
Add pycore_utils.h internal header file. Move the following APIs to pycore_utils.h: * _PyObject_ASSERT() macro * _PyObject_ASSERT_FAILED_MSG() macro * _PyObject_ASSERT_FROM() macro * _PyObject_ASSERT_WITH_MSG() macro * _PyObject_AssertFailed() function
vstinner
force-pushed
the
move_pyobject_assert
branch
from
d1507a0 to
6cba648
Compare
Member
Author
|
Oh. My assumption was that these APIs are not used. By my code search was wrong, in fact multiple projects use these APIs:
I close my PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pycore_utils.h internal header file. Move the following APIs to pycore_utils.h: