Skip to content

gh-139700: Check consistency of the zip64 end of central directory record #139702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

gh-139700: Check consistency of the zip64 end of central directory record #139702

merged 1 commit into from
Oct 7, 2025

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 7, 2025 •
edited by bedevere-app bot
Loading

Support records with "zip64 extensible data" if there are no bytes prepended to the ZIP file.

@serhiy-storchaka
pythongh-139700: Check consistency of the zip64 end of central direct…
8e208c6 
…ory record

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
@serhiy-storchaka serhiy-storchaka added type-security A security issue needs backport to 3.9 needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 7, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 7, 2025
Closed
sethmlarson
sethmlarson approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 162997b into python:main Oct 7, 2025
61 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 7, 2025

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2025
@serhiy-storchaka @miss-islington
pythongh-139700: Check consistency of the zip64 end of central direct…
5454f86 
…ory record (pythonGH-139702)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 7, 2025

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 162997bb70e067668c039700141770687bc8f267 3.13

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 7, 2025

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 162997bb70e067668c039700141770687bc8f267 3.12

@bedevere-app
Copy link

bedevere-app bot commented Oct 7, 2025

GH-139706 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 7, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 7, 2025

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 162997bb70e067668c039700141770687bc8f267 3.11

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 7, 2025

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 162997bb70e067668c039700141770687bc8f267 3.10

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 7, 2025

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 162997bb70e067668c039700141770687bc8f267 3.9

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 7, 2025
@serhiy-storchaka
[3.13] pythongh-139700: Check consistency of the zip64 end of central…
1f2e4ec 
… directory record (pythonGH-139702)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 7, 2025

GH-139708 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 7, 2025
serhiy-storchaka added a commit that referenced this pull request Oct 7, 2025
@serhiy-storchaka
[3.13] gh-139700: Check consistency of the zip64 end of central direc…
333d4a6 
…tory record (GH-139702) (GH-139708)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2025
@serhiy-storchaka @miss-islington
[3.13] pythongh-139700: Check consistency of the zip64 end of central…
d0fb13e 
… directory record (pythonGH-139702) (pythonGH-139708)

(cherry picked from commit 333d4a6)

Co-authored-by: Serhiy Storchaka <[email protected]>
Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2025
@serhiy-storchaka @miss-islington
[3.13] pythongh-139700: Check consistency of the zip64 end of central…
1e1d79a 
… directory record (pythonGH-139702) (pythonGH-139708)

(cherry picked from commit 333d4a6)

Co-authored-by: Serhiy Storchaka <[email protected]>
Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2025
@serhiy-storchaka @miss-islington
[3.13] pythongh-139700: Check consistency of the zip64 end of central…
16a4768 
… directory record (pythonGH-139702) (pythonGH-139708)

(cherry picked from commit 333d4a6)

Co-authored-by: Serhiy Storchaka <[email protected]>
Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2025
@serhiy-storchaka @miss-islington
[3.13] pythongh-139700: Check consistency of the zip64 end of central…
d8a71be 
… directory record (pythonGH-139702) (pythonGH-139708)

(cherry picked from commit 333d4a6)

Co-authored-by: Serhiy Storchaka <[email protected]>
Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)
ambv pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @serhiy-storchaka
[3.9] gh-139700: Check consistency of the zip64 end of central direct…
76437ac 
…ory record (GH-139702) (GH-139708) (#139715)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.

(cherry picked from commit 333d4a6)
(cherry picked from commit 162997b)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @serhiy-storchaka
[3.10] gh-139700: Check consistency of the zip64 end of central direc…
bca11ae 
…tory record (GH-139702) (GH-139708) (#139714)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.

(cherry picked from commit 333d4a6)
(cherry picked from commit 162997b)

Co-authored-by: Serhiy Storchaka <[email protected]>
encukou pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-139700: Check consistency of the zip64 end of central direc…
d11e69d 
…tory record (GH-139702) (GH-139706)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @serhiy-storchaka
[3.12] gh-139700: Check consistency of the zip64 end of central direc…
8392b2f 
…tory record (GH-139702) (GH-139708) (GH-139712)

(cherry picked from commit 333d4a6)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @serhiy-storchaka
[3.11] gh-139700: Check consistency of the zip64 end of central direc…
1d29afb 
…tory record (GH-139702) (GH-139708) (GH-139713)

(cherry picked from commit 333d4a6)

Support records with "zip64 extensible data" if there are no bytes
prepended to the ZIP file.
(cherry picked from commit 162997b)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @sethmlarson