[3.14] gh-90548: Fix musl version detection with --strip-all (GH-137864) #138348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-137864) (cherry picked from commit 6528cf4) Co-authored-by: Marc Mueller <[email protected]> Co-authored-by: Adam Turner <[email protected]>
This was referenced Sep 1, 2025
|
Thanks @vstinner! Looks like this one is ready for merge now, all checks have passed. |
This fix will have to wait for Python 3.14.1. It's not special enough to fit into Python 3.14.0 final release. |
Ahh, I see. Tbh I had hoped it could still be included as it fixes a regression introduced in 6146295 (3.14.0a7). Without the fix I'll need to patch our alpine docker builds for 3.14.0. |
|
cc @hugovk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 6528cf4)
Co-authored-by: Marc Mueller [email protected]
Co-authored-by: Adam Turner [email protected]