Skip to content

gh-137282: Fix tab completion and dir() on concurrent.futures #137214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025
Merged

gh-137282: Fix tab completion and dir() on concurrent.futures #137214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14719f3
fix: dir(concurrent.futures) and tab completion broken
henryiii Jul 29, 2025
8c0858b
docs: add news entry
henryiii Jul 31, 2025
f2482cb
tests: add a __dir__ check to the __all__test
henryiii Jul 31, 2025
d4f7d94
Apply suggestions from code review
henryiii Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/concurrent/futures/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@


def __dir__():
return __all__ + ('__author__', '__doc__')
return __all__ + ['__author__', '__doc__']


def __getattr__(name):
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test___all__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ def check_all(self, modname):
all_set = set(all_list)
self.assertCountEqual(all_set, all_list, "in module {}".format(modname))
self.assertEqual(keys, all_set, "in module {}".format(modname))
# Verify __dir__ is non-empty and doesn't produce an error
self.assertTrue(dir(sys.modules[modname]))

def walk_modules(self, basedir, modpath):
for fn in sorted(os.listdir(basedir)):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-07-31-10-31-56.gh-issue-137282.GOCwIC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix tab completion and :func:`dir` on :mod:`concurrent.futures`.
Loading