gh-136686 Fix UnicodeEncodeError in email.generator.write when encoding multipart/related emails using utf8 policy #136848
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd-trip correctly through `email.parser.parsebytes()` and `as_bytes()`.
|
All commit authors signed the Contributor License Agreement. |
|
Hi, requesting a review from @StanFromIreland as on my end it looks like the review hasn't been requested properly. When you get a chance, could you take a look? Thanks. |
|
Hello Emmet, |
Sorry about that, I saw you had reviewed another pr that made changes in Lib/email, thanks for clarifying that for me. |
Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.