Skip to content

Refactor: Use is_wasm32 flag for is_emscripten or is_wasi for generic checks #136815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 22, 2025
Merged

Refactor: Use is_wasm32 flag for is_emscripten or is_wasi for generic checks #136815

merged 7 commits into from
Jul 22, 2025
+19 −15

Conversation

anistark
Copy link
Contributor

No description provided.

@python-cla-bot
Copy link

python-cla-bot bot commented Jul 19, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

This comment was marked as resolved.

Sign in to view
@StanFromIreland StanFromIreland added skip issue skip news type-refactor Code refactoring (with no changes in behavior) tests Tests in the Lib/test dir labels Jul 19, 2025
@StanFromIreland StanFromIreland requested a review from hoodmane July 19, 2025 14:40
@hoodmane
Copy link
Contributor

Cc @brettcannon . I'm okay with it if he is.

@hoodmane
Copy link
Contributor

@ambv says it needs to be is_wasm32 to make it more than one character different from is_wasi.

@anistark
Copy link
Contributor Author

@ambv says it needs to be is_wasm32 to make it more than one character different from is_wasi.

Done.

@brettcannon brettcannon changed the title Refactor: Use is_wasm flag for is_emscripten or is_wasi for generic checks Refactor: Use is_wasm32 flag for is_emscripten or is_wasi for generic checks Jul 21, 2025
brettcannon
brettcannon requested changes Jul 21, 2025
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I can't edit the PR, so I'm asking for what looks like a redundant comment addition to be removed.

@bedevere-app
Copy link

bedevere-app bot commented Jul 21, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@anistark
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Jul 21, 2025

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from brettcannon July 21, 2025 20:46
@brettcannon brettcannon merged commit aafb143 into python:main Jul 22, 2025
40 checks passed
@brettcannon
Copy link
Member

Thanks, @anistark !

@anistark
Copy link
Contributor Author

Thanks for review 🙌🏼

@anistark anistark deleted the is_wasm branch July 22, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@hoodmane hoodmane hoodmane approved these changes

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir type-refactor Code refactoring (with no changes in behavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anistark @hoodmane @brettcannon @StanFromIreland