Skip to content

[3.6] Doc: Add an optional obsolete header. (GH-13638). #13657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2019
Merged

[3.6] Doc: Add an optional obsolete header. (GH-13638). #13657

merged 2 commits into from
Jun 15, 2019

Conversation

@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented May 29, 2019

(cherry picked from commit 46ed90d)

Co-authored-by: Julien Palard [email protected]

@JulienPalard
[3.6] Doc: Add an optional obsolete header. (pythonGH-13638).
f1a0c85 
(cherry picked from commit 46ed90d)

Co-authored-by: Julien Palard <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2019
Merged
@Mariatta Mariatta requested a review from ned-deily May 29, 2019 16:51
@JulienPalard
Copy link
Member Author

JulienPalard commented May 30, 2019

@ned-deily Hi Ned, would you please merge this, if you like it? See screenshot here: #13638

ned-deily
ned-deily requested changes May 30, 2019
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you also planning to add outdated to conf.py?

Doc/tools/templates/layout.html Outdated
<div id="outdated-warning" style="padding: .5em; text-align: center; background-color: #FFBABA; color: #6A0E0E;">
{% trans %}This document is for an old version of Python that is no longer supported.
You should upgrade, and read the {% endtrans %}
<a href="/3/{{ pagename }}{{ file_suffix }}">{% trans %} Python documentation for the last stable release {% endtrans %}</a>.
Copy link
Member

@ned-deily ned-deily May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using "most recent" or "current" rather than "last" to avoid ambiguity ("most recent" vs "final").

@bedevere-bot
Copy link

bedevere-bot commented May 30, 2019

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@brettcannon brettcannon added the docs Documentation in the Doc dir label May 30, 2019
@JulienPalard
Copy link
Member Author

JulienPalard commented Jun 2, 2019

Are you also planning to add outdated to conf.py?

I think I'll add it thrue docsbuild-scripts, not via the file, so for future releases I won't have to commit the boolean to conf.py.

@JulienPalard
Copy link
Member Author

JulienPalard commented Jun 15, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Jun 15, 2019

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

ned-deily
ned-deily approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ned-deily ned-deily merged commit 78309c9 into python:3.6 Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JulienPalard @bedevere-bot @ned-deily @brettcannon @the-knights-who-say-ni