Skip to content

gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and ** #136395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2025
Merged

gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and ** #136395

merged 5 commits into from
Oct 24, 2025
+23 −36

Conversation

@Tapeline
Copy link
Contributor

@Tapeline Tapeline commented Jul 7, 2025 •
edited by bedevere-app bot
Loading

Solved removing function name from error message entirely

@Tapeline Tapeline requested a review from markshannon as a code owner July 7, 2025 19:47
@python-cla-bot
Copy link

python-cla-bot bot commented Jul 7, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@Tapeline Tapeline changed the title gh-12345: Fix inconsistent TypeError messages regarding invalid values after * and ** gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and ** Jul 7, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 7, 2025
Open
sobolevn
sobolevn reviewed Jul 7, 2025
View reviewed changes
sergey-miryanov
sergey-miryanov reviewed Jul 8, 2025
View reviewed changes
efimov-mikhail
efimov-mikhail approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@efimov-mikhail efimov-mikhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sobolevn
sobolevn reviewed Jul 8, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it :)

sobolevn
sobolevn approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tapeline
Copy link
Contributor Author

Tapeline commented Jul 27, 2025

@markshannon, could you please review this?

@Tapeline
Copy link
Contributor Author

Tapeline commented Aug 3, 2025 •
edited
Loading

Hi, @hugovk, could you please take a look at the error message wording change, since you are an RM. Do you think it looks better now? :)

Eclips4
Eclips4 approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

ashm-dev
ashm-dev approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@ashm-dev ashm-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Eclips4 Eclips4 enabled auto-merge (squash) October 24, 2025 18:47
sergey-miryanov
sergey-miryanov approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@sergey-miryanov sergey-miryanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Eclips4 Eclips4 merged commit 4f8e7b5 into python:main Oct 24, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes

@sobolevn sobolevn sobolevn approved these changes

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

+1 more reviewer

@ashm-dev ashm-dev ashm-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Tapeline @sergey-miryanov @sobolevn @efimov-mikhail @picnixz @Eclips4 @ashm-dev