gh-135755: Document the new PyFunction_GET_BUILTINS macro
#135934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
docs
38 tasks
encukou
reviewed
Jun 25, 2025
Comment on lines
+150
to
+152
| This function cannot fail and does not do error checking; passing anything | ||
| other than an instance of :c:data:`PyFunction_Type` is undefined behavior. | ||
| There is no ``PyFunction_Get*`` equivalent for this function. |
There was a problem hiding this comment.
Hm, I don't think C API WG would approve.
Should this function be in a private header (and with an underscore) instead? It looks untested as well.
There was a problem hiding this comment.
It's sort of tested. I'm not opposed to making it private.
There was a problem hiding this comment.
That looks like it's used in a test -- the test assumes that it's working?
Yeah, the more I look into it, the better making it private seems.
cc @ericsnowcurrently, who added PyFunction_GET_BUILTINS in #133128
There was a problem hiding this comment.
I'll put up an alternate PR.
There was a problem hiding this comment.
FWIW, I agree with making it internal-only.
|
Superseded by #135938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--135934.org.readthedocs.build/