[3.14] gh-126112: Fix test_os.TimerfdTests: use 10 ms resolution (GH-135681) #135704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onGH-135681) Use 10 ms for CLOCK_RES instead of 100 ms to tolerate slow buildbots. (cherry picked from commit 5c25c88) Co-authored-by: Victor Stinner <[email protected]>
newfadel
approved these changes
Jun 19, 2025
newfadel
left a comment
newfadel
left a comment
There was a problem hiding this comment.
The change to use a 10 ms resolution instead of 100 ms for CLOCK_RES in test_os.TimerfdTests is a good improvement to make the tests more robust, especially for slower build environments. This addresses potential flakiness due to timing sensitivities. It's a positive step for test reliability. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 10 ms for CLOCK_RES instead of 100 ms to tolerate slow buildbots.
(cherry picked from commit 5c25c88)
Co-authored-by: Victor Stinner [email protected]