gh-135698: Fix _interpqueues.create(): max_size >= 0 #135703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that the queue maximum size is greater than or equal to 0.
vstinner
added
skip news
needs backport to 3.13
Member
Author
|
@ericsnowcurrently: Would you mind to review my change? |
Comment on lines
+1491
to
+1495
| if (maxsize < 0) { | ||
| PyErr_SetString(PyExc_ValueError, | ||
| "max_size must be greater than or equal to 0"); | ||
| return NULL; | ||
| } |
Member
There was a problem hiding this comment.
A negative value is fine. That's the same as queue.Queue. The logic (and the assert) in _queue_is_full() is actually wrong. I'll put up a PR.
Member
Author
There was a problem hiding this comment.
Oh I see! I closed my PR.
Member
There was a problem hiding this comment.
Thanks for taking time on this!
AA-Turner
removed
needs backport to 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the queue maximum size is greater than or equal to 0.
_interpqueuesmoduledue to queue being created with negativemaxsize#135698