Skip to content

[3.13] gh-135496: Fix f string exclamation mark error typo (GH-135495) #135501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2025
Merged

[3.13] gh-135496: Fix f string exclamation mark error typo (GH-135495) #135501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2527963
Update test_fstring.py
MeGaGiGaGon Jun 14, 2025
2e14cfe
Update action_helpers.c
MeGaGiGaGon Jun 14, 2025
8dcf943
Create 2025-06-14-01-01-14.gh-issue-135496.ER0Me3.rst
MeGaGiGaGon Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_fstring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,7 +1370,7 @@ def test_conversions(self):
for conv in ' s', ' s ':
self.assertAllRaise(SyntaxError,
"f-string: conversion type must come right after the"
" exclamanation mark",
" exclamation mark",
["f'{3!" + conv + "}'"])

self.assertAllRaise(SyntaxError,
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2025-06-14-01-01-14.gh-issue-135496.ER0Me3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix typo in the f-string conversion type error ("exclamanation" -> "exclamation").
2 changes: 1 addition & 1 deletion Parser/action_helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ _PyPegen_check_fstring_conversion(Parser *p, Token* conv_token, expr_ty conv)
if (conv_token->lineno != conv->lineno || conv_token->end_col_offset != conv->col_offset) {
return RAISE_SYNTAX_ERROR_KNOWN_RANGE(
conv_token, conv,
"f-string: conversion type must come right after the exclamanation mark"
"f-string: conversion type must come right after the exclamation mark"
);
}
return result_token_with_metadata(p, conv, conv_token->metadata);
Expand Down
Loading