Skip to content

Fix warnings set but not used [-Wunused-but-set-variable] in remote_debug.h #135290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix warnings set but not used [-Wunused-but-set-variable] in remote_debug.h #135290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions Python/remote_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,8 +674,6 @@ search_linux_map_for_section(proc_handle_t *handle, const char* secname, const c
}

uintptr_t retval = 0;
int lines_processed = 0;
int matches_found = 0;

while (fgets(line + linelen, linesz - linelen, maps_file) != NULL) {
linelen = strlen(line);
Expand All @@ -700,7 +698,6 @@ search_linux_map_for_section(proc_handle_t *handle, const char* secname, const c
line[linelen - 1] = '\0';
// and prepare to read the next line into the start of the buffer.
linelen = 0;
lines_processed++;

unsigned long start = 0;
unsigned long path_pos = 0;
Expand All @@ -721,7 +718,6 @@ search_linux_map_for_section(proc_handle_t *handle, const char* secname, const c
}

if (strstr(filename, substr)) {
matches_found++;
retval = search_elf_file_for_section(handle, secname, start, path);
if (retval) {
break;
Expand Down Expand Up @@ -840,15 +836,10 @@ search_windows_map_for_section(proc_handle_t* handle, const char* secname, const
MODULEENTRY32W moduleEntry;
moduleEntry.dwSize = sizeof(moduleEntry);
void* runtime_addr = NULL;
int modules_examined = 0;
int matches_found = 0;

for (BOOL hasModule = Module32FirstW(hProcSnap, &moduleEntry); hasModule; hasModule = Module32NextW(hProcSnap, &moduleEntry)) {
modules_examined++;

// Look for either python executable or DLL
if (wcsstr(moduleEntry.szModule, substr)) {
matches_found++;
runtime_addr = analyze_pe(moduleEntry.szExePath, moduleEntry.modBaseAddr, secname);
if (runtime_addr != NULL) {
break;
Expand Down
Loading