Skip to content

Conversation

@jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented May 22, 2019

@jdemeyer jdemeyer changed the title [WIP] bpo-36974: handle inheritance of vectorcall protocol bpo-36974: handle inheritance of vectorcall protocol May 29, 2019
@jdemeyer jdemeyer marked this pull request as ready for review May 29, 2019 13:26
@jdemeyer jdemeyer requested review from 1st1 and asvetlov as code owners May 29, 2019 13:26
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for asyncio part

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!
(Not merging right now as I won't be able to watch buildbots)

@jdemeyer jdemeyer mentioned this pull request May 30, 2019
@encukou encukou merged commit 735e8af into python:master May 30, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants