bpo-2180: Treat line continuation at EOF as a SyntaxError
#13401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
force-pushed
the
continuation_at_eof_bpo-2180
branch
3 times, most recently
from
53334f7 to
3876813
Compare
This makes the parser consistent with the tokenize module (already the case
in `pypy`).
sample
------
```python
x = 5\
```
before
------
```console
$ python3 t.py
$ python3 -mtokenize t.py
t.py:2:0: error: EOF in multi-line statement
```
after
-----
```console
$ ./python t.py
File "t.py", line 3
x = 5\
^
SyntaxError: unexpected EOF while parsing
$ ./python -m tokenize t.py
t.py:2:0: error: EOF in multi-line statement
```
asottile
force-pushed
the
continuation_at_eof_bpo-2180
branch
from
3876813 to
9437230
Compare
gpshead
reviewed
May 18, 2019
gpshead
approved these changes
May 18, 2019
|
@asottile: Status check is done, and it's a failure ❌ . |
2 similar comments
|
@asottile: Status check is done, and it's a failure ❌ . |
|
@asottile: Status check is done, and it's a failure ❌ . |
tirkarthi
reviewed
May 18, 2019
|
@asottile: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the parser consistent with the tokenize module (already the case
in
pypy).sample
before
after
https://bugs.python.org/issue2180