-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
gh-133829: Update zipimport example to not mention Python 2.3 #133835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again. |
No response for over a week. I don't think @AA-Turner will reply |
Hi Rihaan. Your enthusiasm is commendable, but I would ask that you stop frequently pinging me and other core developers. This PR remains in my queue to look at (& hopefully merge). However, there are nearly 2,000 open PRs in total. If I were to spend just a minute reviewing each, it would take over 30 hours. The devguide recommends a month to give you an indication of the timelines that the project can run on, and to set your expectations -- it is unfair to others if we unduly prioritise your PR solely as you ping us more frequently. These timelines should be used as a guide, rather than as a target. As a reminder, we are volunteers giving up our time for free to contribute to and maintain the project, so sometimes things do take a bit longer. I regret that this PR is still outstanding, but to be transparent, I have been reluctant to engage in this thread given some of the comments. A |
Sorry for being a bit annoying ... when I'm stressed sometimes I do t think and make comments like that especially around finals time I promise I didn't mean it the way it came across, i won’t again. Thank you though for your time
…On Wed, Jul 9, 2025 at 18:53 Adam Turner ***@***.***> wrote:
*AA-Turner* left a comment (python/cpython#133835)
<#133835 (comment)>
Hi Rihaan. Your enthusiasm is commendable, but I would ask that you stop
frequently pinging me and other core developers. This PR remains in my
queue to look at (& hopefully merge). However, there are nearly 2,000 open
PRs in total. If I were to spend just a minute reviewing each, it would
take over 30 hours. The devguide recommends a month to give you an
indication of the timelines that the project can run on, and to set your
expectations -- it is unfair to others if we unduly prioritise your PR
solely as you ping us more frequently. These timelines should be used as a
guide, rather than as a target.
As a reminder, we are volunteers giving up our time for free to contribute
to and maintain the project, so sometimes things do take a bit longer. I
regret that this PR is still outstanding, but to be transparent, I have
been reluctant to engage in this thread given some of the comments.
A
—
Reply to this email directly, view it on GitHub
<#133835 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNITW5ZOQJLO76WZY3JSXG33HUJWXAVCNFSM6AAAAAB425AMWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANJSGY3DGMJTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I'll give Adam until the end of the month if they want to speak up, otherwise I'll plan to merge (roughly) then. |
Thanks! (Also it's my birthday that day so I don't know if I will be available. I might have lots of time or no time) |
CC @brettcannon |
Doc/library/zipimport.rst
Outdated
Length Date Time Name | ||
-------- ---- ---- ---- | ||
8467 11-26-02 22:30 jwzthreading.py | ||
8467 05-11-25 12:29 example.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use a clearly example time, rather than one that will get dated?
8467 05-11-25 12:29 example.py | |
8467 01-01-00 12:34 example.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best not so we will know (or people will notice) to update the example if we ever make breaking changes to zipimport. I don't think it is worth it, but it doesn't matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand your comment. The code block here is for unzip
, where we're already inventing an archive for expository purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My phone has aggressive autocorrect and my misspelling resulted in unzip turning into zipimporter.
But on second thoughts, by keeping the time and date specific, we know what version of Python it was written in and if we ever change anything even methods we keep for expository purposes someone will notice and fix it.
I also don't think it matters that much :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But on second thoughts, by keeping the time and date specific, we know what version of Python it was written in and if we ever change anything even methods we keep for expository purposes someone will notice and fix it.
I'm not sure I understand. If we break this (which is unlikely), we'll update the example anyway. Knowing when something was written generally doesn't have much maintenance benefit.
I think I agree with Adam -- it'd be better to make this clearer that it's an example and not supposed to be actual data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated date and time example to
01-01-00 12:30
Thanks all! A |
Thanks @sharktide for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Thanks @sharktide for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…pythonGH-133835) (cherry picked from commit c7a097c) Co-authored-by: R Chintan Meher <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
…pythonGH-133835) (cherry picked from commit c7a097c) Co-authored-by: R Chintan Meher <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
GH-138273 is a backport of this pull request to the 3.13 branch. |
GH-138274 is a backport of this pull request to the 3.14 branch. |
GH-133835) (#138273) Co-authored-by: R Chintan Meher <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
GH-133835) (#138274) Co-authored-by: R Chintan Meher <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
Thank you all! |
…example (pythonGH-133835) (python#138274) Co-authored-by: R Chintan Meher <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
…python#133835) Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
#133829
Updates this zipimport example: https://docs.python.org/3.14/library/zipimport.html#examples which uses Python 2.3 to use 3.x and pip.pyz as the new example
This will close #133829
Ready for review
📚 Documentation preview 📚: https://cpython-previews--133835.org.readthedocs.build/en/133835/library/zipimport.html#examples