Skip to content

Conversation

sharktide
Copy link
Contributor

@sharktide sharktide commented May 10, 2025

#133829

Updates this zipimport example: https://docs.python.org/3.14/library/zipimport.html#examples which uses Python 2.3 to use 3.x and pip.pyz as the new example

This will close #133829

Ready for review


📚 Documentation preview 📚: https://cpython-previews--133835.org.readthedocs.build/en/133835/library/zipimport.html#examples

@tomasr8 tomasr8 changed the title gh-133829 Update zipimport example to use pip.pyz gh-133829: Update zipimport example to use pip.pyz May 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sharktide
Copy link
Contributor Author

I have made the requested changes; please review again.

@sharktide
Copy link
Contributor Author

sharktide commented Jul 9, 2025

We generally try to avoid overriding another core dev's request for changes.

@AA-Turner Have your concerns been addressed? I'm comfortable with merging this if you confirm that you don't want to block.

No response for over a week. I don't think @AA-Turner will reply

@AA-Turner
Copy link
Member

Hi Rihaan. Your enthusiasm is commendable, but I would ask that you stop frequently pinging me and other core developers. This PR remains in my queue to look at (& hopefully merge). However, there are nearly 2,000 open PRs in total. If I were to spend just a minute reviewing each, it would take over 30 hours. The devguide recommends a month to give you an indication of the timelines that the project can run on, and to set your expectations -- it is unfair to others if we unduly prioritise your PR solely as you ping us more frequently. These timelines should be used as a guide, rather than as a target.

As a reminder, we are volunteers giving up our time for free to contribute to and maintain the project, so sometimes things do take a bit longer. I regret that this PR is still outstanding, but to be transparent, I have been reluctant to engage in this thread given some of the comments.

A

@sharktide
Copy link
Contributor Author

sharktide commented Jul 9, 2025 via email

@brettcannon
Copy link
Member

I'll give Adam until the end of the month if they want to speak up, otherwise I'll plan to merge (roughly) then.

@sharktide
Copy link
Contributor Author

sharktide commented Aug 15, 2025

I'll give Adam until the end of the month if they want to speak up, otherwise I'll plan to merge (roughly) then.

Thanks! (Also it's my birthday that day so I don't know if I will be available. I might have lots of time or no time)

@sharktide
Copy link
Contributor Author

CC @brettcannon

Length Date Time Name
-------- ---- ---- ----
8467 11-26-02 22:30 jwzthreading.py
8467 05-11-25 12:29 example.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use a clearly example time, rather than one that will get dated?

Suggested change
8467 05-11-25 12:29 example.py
8467 01-01-00 12:34 example.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best not so we will know (or people will notice) to update the example if we ever make breaking changes to zipimport. I don't think it is worth it, but it doesn't matter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your comment. The code block here is for unzip, where we're already inventing an archive for expository purposes.

Copy link
Contributor Author

@sharktide sharktide Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My phone has aggressive autocorrect and my misspelling resulted in unzip turning into zipimporter.

But on second thoughts, by keeping the time and date specific, we know what version of Python it was written in and if we ever change anything even methods we keep for expository purposes someone will notice and fix it.

I also don't think it matters that much :).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But on second thoughts, by keeping the time and date specific, we know what version of Python it was written in and if we ever change anything even methods we keep for expository purposes someone will notice and fix it.

I'm not sure I understand. If we break this (which is unlikely), we'll update the example anyway. Knowing when something was written generally doesn't have much maintenance benefit.

I think I agree with Adam -- it'd be better to make this clearer that it's an example and not supposed to be actual data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right.

Copy link
Contributor Author

@sharktide sharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated date and time example to

01-01-00 12:30

@AA-Turner AA-Turner merged commit c7a097c into python:main Aug 31, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 31, 2025
@AA-Turner
Copy link
Member

Thanks all!

A

@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 31, 2025
@miss-islington-app
Copy link

Thanks @sharktide for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @sharktide for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 31, 2025
…pythonGH-133835)

(cherry picked from commit c7a097c)

Co-authored-by: R Chintan Meher <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 31, 2025
…pythonGH-133835)

(cherry picked from commit c7a097c)

Co-authored-by: R Chintan Meher <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 31, 2025

GH-138273 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 31, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 31, 2025

GH-138274 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 31, 2025
AA-Turner added a commit that referenced this pull request Aug 31, 2025
GH-133835) (#138273)

Co-authored-by: R Chintan Meher <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
hugovk pushed a commit that referenced this pull request Aug 31, 2025
GH-133835) (#138274)

Co-authored-by: R Chintan Meher <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
@sharktide
Copy link
Contributor Author

sharktide commented Aug 31, 2025

Thanks all!

A

Thank you all!

kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…example (pythonGH-133835) (python#138274)

Co-authored-by: R Chintan Meher <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
…python#133835)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update zipimport example (uses Python 2.3)
7 participants