Skip to content

gh-132553: Build the perf tool without buildid cache #132663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

gh-132553: Build the perf tool without buildid cache #132663

merged 1 commit into from
Apr 18, 2025

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 17, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Apr 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2025
Closed
@pablogsal pablogsal added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes skip news labels Apr 17, 2025
vstinner
vstinner approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ambv ambv merged commit e01e582 into python:main Apr 18, 2025
52 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Apr 18, 2025

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2025
@pablogsal @miss-islington
pythongh-132553: Build the perf tool without buildid cache (pythonGH-…
b41e8bd 
…132663)

(cherry picked from commit e01e582)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@miss-islington-app
Copy link

miss-islington-app bot commented Apr 18, 2025

Sorry, @pablogsal and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e01e5829020e517eb68a47da4dd65926a9d144de 3.12

@bedevere-app
Copy link

bedevere-app bot commented Apr 18, 2025

GH-132681 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 18, 2025
ambv pushed a commit that referenced this pull request Apr 18, 2025
@miss-islington @pablogsal
[3.13] gh-132553: Build the perf tool without buildid cache (GH-132663)…
b3d4980 
… (GH-132681)

(cherry picked from commit e01e582)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 19, 2025

GH-132718 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 19, 2025
pablogsal added a commit that referenced this pull request Apr 25, 2025
@vstinner @pablogsal
[3.12] gh-132553: Build the perf tool without buildid cache (GH-132663)…
aeb3a6f 
… (#132718)

gh-132553: Build the perf tool without buildid cache (GH-132663)

(cherry picked from commit e01e582)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@ambv ambv

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal @vstinner @ambv