Skip to content

gh-128002: simplify all_tasks to use PyList_Extend instead of manual iteration #129942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

gh-128002: simplify all_tasks to use PyList_Extend instead of manual iteration #129942

merged 1 commit into from
Feb 10, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Feb 10, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 10, 2025
Closed
9 tasks
asvetlov
asvetlov approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kumaraditya303
Copy link
Contributor Author

Thanks for all your reviews @asvetlov

@kumaraditya303 kumaraditya303 merged commit 7246b91 into python:main Feb 10, 2025
51 checks passed
@kumaraditya303 kumaraditya303 deleted the simple branch February 10, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @asvetlov