Skip to content

gh-118761: improve import time for secrets #128738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-118761: improve import time for secrets #128738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f536c5
Improve import time of the `secrets` module.
picnixz Jan 9, 2025
0c009fa
blurb
picnixz Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/secrets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
]


import base64

from hmac import compare_digest
from random import SystemRandom

Expand Down Expand Up @@ -67,5 +65,7 @@ def token_urlsafe(nbytes=None):
'Drmhze6EPcv0fN_81Bj-nA'

"""
import base64

tok = token_bytes(nbytes)
return base64.urlsafe_b64encode(tok).rstrip(b'=').decode('ascii')
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-01-10-12-19-42.gh-issue-118761.i4yXe3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve import time of :mod:`secrets` by a factor two. This is achieved by
importing :mod:`base64` on demand. Patch by Bénédikt Tran.
Loading