Skip to content

gh-127740: Add some more tests for earlier PR #127756 #127818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2024
Merged

gh-127740: Add some more tests for earlier PR #127756 #127818

merged 3 commits into from
Dec 12, 2024

Conversation

@srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Dec 11, 2024 •
edited
Loading

gh-127740: Add some more tests for earlier PR #127756

via - #127756 (comment)

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Dec 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 11, 2024
Closed
@srinivasreddy srinivasreddy marked this pull request as ready for review December 11, 2024 11:16
@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Dec 11, 2024

cc @hauntsaninja @cfbolz

@srinivasreddy srinivasreddy mentioned this pull request Dec 11, 2024
Merged
ZeroIntensity
ZeroIntensity reviewed Dec 11, 2024
View reviewed changes
hauntsaninja
hauntsaninja approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

hauntsaninja
hauntsaninja approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja enabled auto-merge (squash) December 12, 2024 02:18
@hauntsaninja hauntsaninja merged commit c33b6fb into python:main Dec 12, 2024
40 checks passed
srinivasreddy added a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@srinivasreddy
pythongh-127740: Add some more tests for earlier PR python#127756 (py…
ad2e37c 
…thon#127818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srinivasreddy @hauntsaninja @ZeroIntensity @skirpichev