Skip to content

gh-122744: test_venv: ignore pip's complaint about missing ssl #122776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

gh-122744: test_venv: ignore pip's complaint about missing ssl #122776

merged 1 commit into from
Aug 8, 2024

Conversation

@encukou
Copy link
Member

@encukou encukou commented Aug 7, 2024 •
edited by bedevere-app bot
Loading

This is a new warning emitted by pip for its “Using system certificate stores” feature.

@encukou encukou requested a review from vsajip as a code owner August 7, 2024 12:39
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Aug 7, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 7, 2024
Closed
@sethmlarson
Copy link
Contributor

sethmlarson commented Aug 7, 2024

I can't speak for pip maintainers, but I do wonder if the phrasing of "truststore" is a hold-over from when it was an optional feature enabled by flag (ie --use-feature=truststore) instead of the actual feature name? Maybe the skipped warning can look for ssl support is missing instead of the full sentence?

@encukou
Copy link
Member Author

encukou commented Aug 8, 2024

Well, we can easily adjust whenever pip is updated again -- it'll be in a new CPython PR, anyway.
I'll merge now to unblock the buildbots, useing the full message to avoid guessing about the future.

@encukou encukou merged commit 0d9c123 into python:main Aug 8, 2024
@encukou encukou deleted the whats-this-truststore-thing branch August 8, 2024 09:21
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 8, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 8, 2024

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Aug 8, 2024

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@encukou @miss-islington
pythongh-122744: test_venv: ignore pip's complaint about missing ssl (p…
f2e4e61 
…ythonGH-122776)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2024
@encukou @miss-islington
pythongh-122744: test_venv: ignore pip's complaint about missing ssl (p…
f60b467 
…ythonGH-122776)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 8, 2024

GH-122822 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Aug 8, 2024
@bedevere-app
Copy link

bedevere-app bot commented Aug 8, 2024

GH-122823 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 8, 2024
encukou added a commit that referenced this pull request Aug 9, 2024
@miss-islington @encukou
[3.13] gh-122744: test_venv: ignore pip's complaint about missing ssl (…
3ba75ae 
…GH-122776) (GH-122823)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <[email protected]>
encukou added a commit that referenced this pull request Aug 9, 2024
@miss-islington @encukou
[3.12] gh-122744: test_venv: ignore pip's complaint about missing ssl (…
c536f59 
…GH-122776) (GH-122822)

(cherry picked from commit 0d9c123)

Co-authored-by: Petr Viktorin <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@encukou @blhsing
pythongh-122744: test_venv: ignore pip's complaint about missing ssl (p…
ed4c919 
…ythonGH-122776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou @sethmlarson @vsajip