Skip to content

gh-122759: Remove assert from RERAISE error handling #122760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

gh-122759: Remove assert from RERAISE error handling #122760

merged 1 commit into from
Aug 7, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 6, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from Fidget-Spinner August 6, 2024 21:51
@sobolevn sobolevn requested a review from markshannon as a code owner August 6, 2024 21:51
@bedevere-app bedevere-app bot mentioned this pull request Aug 6, 2024
Closed
markshannon
markshannon approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sobolevn
Copy link
Member Author

sobolevn commented Aug 7, 2024

test_logging failures do not seem related, I will merge this now. Thanks for the review.
Please, let me know if this is worth backporting to 3.13 (rc) and 3.12

@sobolevn sobolevn merged commit 61a8bf2 into python:main Aug 7, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@sobolevn @blhsing
pythongh-122759: Remove assert from RERAISE error handling (pytho…
0c5e26f 
…n#122760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @markshannon