Skip to content

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Jul 25, 2024

This one is a lot like GH-122253, in that it's mostly done for completeness so that we can stay in tier two across a LOAD_ATTR_PROPERTY. No real impact on stats or perf, beyond the obvious.

This is a minor change for the instruction itself, though: the current instruction can't be split up, since it needs two cache entries (a function and a version for that function) to be active at the same time. This replaces the exact function version check with looser checks on all of the members of the code object that we care about.

@brandtbucher brandtbucher added performance Performance or resource usage skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 25, 2024
@brandtbucher brandtbucher self-assigned this Jul 25, 2024
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I suspect we won't see any benefit from this until we can trace through the _PUSH_FRAME, but it is good to remove another edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants