Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

Share common code for tests for PyLong_As*() functions.

Based on test changes in #120390. The same helper is used in tests for all signed and unsigned integer types. negative_value_error is now an exception class, not a boolean.

Share common code for tests for PyLong_As*() functions.

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 22, 2024

GH-122137 is a backport of this pull request to the 3.13 branch.

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 69f2dc5c06e62b4a9eb4da8f0cd456cc09b998ed 3.12

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 22, 2024
@serhiy-storchaka
Copy link
Member Author

Thank you, Victor.

serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 23, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 23, 2024

GH-122151 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 23, 2024
serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants