gh-121660: Fix ga_getitem by explicitly checking for NULL result
#121661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
added
needs backport to 3.12
JelleZijlstra
approved these changes
Jul 13, 2024
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good. It appears this can only happen if there is a memory failure (e.g., PyTuple_Pack fails), so it's not feasible to test for it, but we should still fix this.
IljaManakov
added a commit
to IljaManakov/cpython
that referenced
this pull request
Jul 14, 2024
IljaManakov
added a commit
to IljaManakov/cpython
that referenced
this pull request
Jul 14, 2024
IljaManakov
added a commit
to IljaManakov/cpython
that referenced
this pull request
Jul 14, 2024
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2024
…esult (pythonGH-121661) (cherry picked from commit bb802db) Co-authored-by: sobolevn <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2024
…esult (pythonGH-121661) (cherry picked from commit bb802db) Co-authored-by: sobolevn <[email protected]>
|
GH-121761 is a backport of this pull request to the 3.13 branch. |
|
GH-121762 is a backport of this pull request to the 3.12 branch. |
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ga_getitemcan fail ifPy_GenericAliasreturnsNULL#121660