gh-121445: C implementation for fnmatch
#121446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
commented
Jul 6, 2024
Member
Author
|
I forgot that MSVC didn't have an implementation of fnmatch... I'll add a guard for Windows so that it uses the pure Python implementation. |
picnixz
commented
Jul 7, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
- add convenience macros - make some macros private
Previous improvement: 2.05x. This improvement: 2.8x.
See pythongh-123122 for the rationale.
Member
Author
|
See issue for the rationale of closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurescript.lru_cacheos.path.normcasefnmatch.fnmatchfnmatch.fnmathcasefnmatch.translatefnmatch#121445