Skip to content

bpo-33608: Use _Py_AddPendingCall() in _PyCrossInterpreterData_Release(). #12024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2019
Merged

bpo-33608: Use _Py_AddPendingCall() in _PyCrossInterpreterData_Release(). #12024

merged 5 commits into from
Mar 1, 2019

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Feb 24, 2019 •
edited by bedevere-bot
Loading

@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner February 24, 2019 23:56
@ericsnowcurrently ericsnowcurrently merged commit b05b711 into python:master Mar 1, 2019
@ericsnowcurrently ericsnowcurrently deleted the xid-pending-calls branch March 1, 2019 19:35
@vstinner vstinner mentioned this pull request Mar 4, 2019
Merged
vstinner added a commit that referenced this pull request Mar 4, 2019
@vstinner
Revert: bpo-33608: Factor out a private, per-interpreter _Py_AddPendi…
4d61e6e 
…ngCall(). (GH-11617) (GH-12159)

* Revert "bpo-36097: Use only public C-API in the_xxsubinterpreters module (adding as necessary). (#12003)"

This reverts commit bcfa450.

* Revert "bpo-33608: Simplify ceval's DISPATCH by hoisting eval_breaker ahead of time. (gh-12062)"

This reverts commit bda918b.

* Revert "bpo-33608: Use _Py_AddPendingCall() in _PyCrossInterpreterData_Release(). (gh-12024)"

This reverts commit b05b711.

* Revert "bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (GH-11617)"

This reverts commit ef4ac96.
@ericsnowcurrently ericsnowcurrently restored the xid-pending-calls branch March 8, 2019 16:23
@ericsnowcurrently ericsnowcurrently mentioned this pull request Mar 15, 2019
Merged
ericsnowcurrently added a commit that referenced this pull request Apr 12, 2019
@ericsnowcurrently
bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (
f13c5c8 
gh-12360)

This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 different bugs in the original PRs and have fixed them here.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot