Skip to content

[3.7] bpo-34211: fix _abc.c compile error on Cygwin (GH-8445) #12004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2019
Merged

[3.7] bpo-34211: fix _abc.c compile error on Cygwin (GH-8445) #12004

merged 1 commit into from
Feb 24, 2019

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 24, 2019 •
edited by bedevere-bot
Loading

(cherry picked from commit abe5922)

Co-authored-by: E. M. Bray [email protected]

https://bugs.python.org/issue34211

@embray @miss-islington
fix _abc.c compile error on Cygwin (pythonGH-8445)
5f51a4b 
(cherry picked from commit abe5922)

Co-authored-by: E. M. Bray <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Feb 24, 2019
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 24, 2019

@embray and @methane: Status check is done, and it's a failure ❌ .

@methane methane changed the title [3.7] fix _abc.c compile error on Cygwin (GH-8445) [3.7] bpo-34211: fix _abc.c compile error on Cygwin (GH-8445) Feb 24, 2019
@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 24, 2019

@embray and @methane: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 24, 2019

@embray and @methane: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 24, 2019

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 8efa328 into python:3.7 Feb 24, 2019
@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 24, 2019

@embray and @methane: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Feb 24, 2019

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington miss-islington deleted the backport-abe5922-3.7 branch February 24, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @methane @the-knights-who-say-ni @bedevere-bot @embray