Skip to content

gh-117873: Revert _posixshmem.shm_open() change #118901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

gh-117873: Revert _posixshmem.shm_open() change #118901

merged 1 commit into from
May 13, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 10, 2024 •
edited by bedevere-app bot
Loading

@vstinner vstinner requested a review from gpshead as a code owner May 10, 2024 13:29
@bedevere-app bedevere-app bot mentioned this pull request May 10, 2024
Closed
@vstinner vstinner mentioned this pull request May 10, 2024
Merged
@nineteendo
Copy link
Contributor

nineteendo commented May 10, 2024 •
edited
Loading

Reason for revert:

This PR does not address the concerns of the issue: the METH_VARARGS calling convention is still used.

See discussion in #118012. You can skip news.

@vstinner vstinner merged commit 7d7eec5 into python:main May 13, 2024
@vstinner vstinner deleted the revert_shm branch May 13, 2024 14:03
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-117873: Revert _posixshmem.shm_open() change (python#118901)
9f92c16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @nineteendo