Skip to content

[gh-117657] Fix some issues with TSAN in typeobject #118249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

[gh-117657] Fix some issues with TSAN in typeobject #118249

merged 1 commit into from
Apr 30, 2024

Conversation

DinoV
Copy link
Contributor

@DinoV DinoV commented Apr 24, 2024 •
edited by bedevere-app bot
Loading

The tp_version field is updated under a lock, but it can be read lock-free. The assigns and reads from it need to use relaxed atomics.

@bedevere-app bedevere-app bot mentioned this pull request Apr 24, 2024
Open
@DinoV DinoV marked this pull request as ready for review April 24, 2024 23:42
@DinoV DinoV requested a review from markshannon as a code owner April 24, 2024 23:42
@DinoV DinoV requested review from colesbury and mpage April 25, 2024 16:19
@DinoV DinoV force-pushed the nogil_type_tsan branch from f6d482e to 8daa151 Compare April 30, 2024 18:41
@DinoV DinoV merged commit 19d468a into python:main Apr 30, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@DinoV @SonicField
[pythongh-117657] Fix some issues with TSAN in typeobject (python#118249
c4626c1 
)

Fix some racing reads in typebobject.c
@DinoV DinoV deleted the nogil_type_tsan branch May 31, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@mpage mpage Awaiting requested review from mpage

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DinoV @colesbury