Skip to content

gh-117594: Require cpu resource to test_search_anchor_at_beginning #117595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2024
Merged

gh-117594: Require cpu resource to test_search_anchor_at_beginning #117595

merged 2 commits into from
Apr 7, 2024

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Apr 7, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Apr 7, 2024
@corona10 corona10 removed the tests Tests in the Lib/test dir label Apr 7, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2024
Closed
@corona10 corona10 requested a review from encukou April 7, 2024 06:12
@corona10 corona10 added the needs backport to 3.12 only security fixes label Apr 7, 2024
@corona10 corona10 changed the title gh-117594: Requre cpu resource to test_search_anchor_at_beginning gh-117594: Require cpu resource to test_search_anchor_at_beginning Apr 7, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But maybe add a clarifying comment? Something like: "The test is not slow by itself, but it relies on the absolute computation time and can fail on very slow computers (hundreds times slower than the mainstream PCs)".

@corona10 corona10 enabled auto-merge (squash) April 7, 2024 23:31
@corona10 corona10 merged commit 784623c into python:main Apr 7, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Apr 7, 2024

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Apr 7, 2024

Sorry, @corona10, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 784623c63c45a4d13dfb04318c39fdb1ab790218 3.12

@bedevere-app
Copy link

bedevere-app bot commented Apr 8, 2024

GH-117616 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 8, 2024
corona10 added a commit to corona10/cpython that referenced this pull request Apr 8, 2024
@corona10
pythongh-117594: Require cpu resource to test_search_anchor_at_beginn…
9abe12b 
…ing (pythongh-117595)

(cherry picked from commit 784623c)
corona10 added a commit that referenced this pull request Apr 8, 2024
@corona10
[3.12] gh-117594: Require cpu resource to test_search_anchor_at_begin…
2449441 
…ning (g… (gh-117616)

gh-117594: Require cpu resource to test_search_anchor_at_beginning (gh-117595)

(cherry picked from commit 784623c)
@corona10 corona10 deleted the gh-117594 branch April 8, 2024 01:45
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-117594: Require cpu resource to test_search_anchor_at_beginn…
6fab267 
…ing (pythongh-117595)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees

@corona10 corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10 @serhiy-storchaka @Eclips4