GH-117512: Allow 64-bit JIT operands on 32-bit platforms #117527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
type-bug
Fidget-Spinner
approved these changes
Apr 4, 2024
markshannon
reviewed
Apr 4, 2024
| patches[HoleValue_OPERAND] = instruction->operand; | ||
| #else | ||
| assert(SIZEOF_VOID_P == 4); | ||
| patches[HoleValue_OPERAND_HI] = instruction->operand >> 32; |
Member
There was a problem hiding this comment.
Should patches become uintptr_t instead of uint64_t? (on all platforms).
Given many of the casts are of the form (uint64_t)some_pointer, changing them to (uintptr_t)some_pointer avoids unnecessary widening on 32 bit platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't burn in anything wider than a pointer, so split 64-bit operands in half on 32-bit platforms and burn them in separately. This doesn't pessimize loads of operands less than the width of a pointer on any platform.
Unblocks GH-117396.