Skip to content

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Apr 2, 2024

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit: do not forget to put the new helper in support/__init__.__all__, I think this should be a public API of support package.
Otherwise LGTM!

@Eclips4
Copy link
Member

Eclips4 commented Apr 2, 2024

Oh, it would be nice if we add a few lines to the Doc/lib/test.rst (likewise for other requires_X helpers)

@colesbury colesbury merged commit 4220514 into python:main Apr 4, 2024
@colesbury colesbury deleted the gh-117478-requires_gil_enabled branch April 4, 2024 18:10
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants