Skip to content

gh-114727: Update os_{openpty|grantpt}_impl to use per module lock. #117017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-114727: Update os_{openpty|grantpt}_impl to use per module lock. #117017

wants to merge 1 commit into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 19, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 19, 2024
Open
@corona10
Copy link
Member Author

corona10 commented Mar 19, 2024 •
edited
Loading

To me, the easy way to mimic GIL for this situation is to lock the module itself.
Please let me know for the better way :)
(I am not sure that it will prevent other cases)

@corona10 corona10 closed this Mar 19, 2024
@corona10
Copy link
Member Author

Change my mind, locking the module will not be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury Awaiting requested review from colesbury

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Assignees
No one assigned
Labels
awaiting core review skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@corona10