Skip to content

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Mar 15, 2024

Small tweak to reduce the size of the stencils for _INIT_CALL_PY_EXACT_ARGS

The base version goes from 983 to 652 bytes (linux x86-64) and the _0 replica goes from 440 to 258 bytes.

@markshannon markshannon requested a review from gvanrossum as a code owner March 15, 2024 10:36
@bedevere-app bedevere-app bot mentioned this pull request Mar 15, 2024
13 tasks
@markshannon markshannon requested review from brandtbucher and removed request for gvanrossum March 15, 2024 10:36
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is the usual suspect of test_multiprocessing. Probably just flaky.

@markshannon markshannon merged commit 950667e into python:main Mar 15, 2024
@markshannon markshannon deleted the attempt-to-shrink-call-sequence branch March 15, 2024 17:16
@brandtbucher
Copy link
Member

Nice find!

There are lots of other instructions with this pattern... should those be updated too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants