Skip to content

Consistently spell out *predicate* instead of *pred*. #116308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2024
Merged

Consistently spell out *predicate* instead of *pred*. #116308

merged 6 commits into from
Mar 4, 2024

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Mar 4, 2024 •
edited by github-actions bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip issue skip news needs backport to 3.12 only security fixes labels Mar 4, 2024
@Privat33r-dev
Copy link
Contributor

Privat33r-dev commented Mar 4, 2024

My guess is that you should apply the changes to the module's source code as well.

Privat33r-dev
Privat33r-dev reviewed Mar 4, 2024
View reviewed changes
@rhettinger
Copy link
Contributor Author

rhettinger commented Mar 4, 2024

My guess is that you should apply the changes to the module's source code as well.

Done.

Privat33r-dev
Privat33r-dev approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Privat33r-dev Privat33r-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR :)

  • The change is consistent: affects all entries
  • The change affects docs in the module as well
  • No misspelling/typos

@rhettinger rhettinger enabled auto-merge (squash) March 4, 2024 15:49
@rhettinger rhettinger merged commit 15dc297 into python:main Mar 4, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 4, 2024

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2024
@rhettinger @miss-islington
Consistently spell out *predicate* instead of *pred*. (pythongh-116308)
6482ae3 
(cherry picked from commit 15dc297)

Co-authored-by: Raymond Hettinger <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 4, 2024

GH-116312 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 4, 2024
rhettinger pushed a commit that referenced this pull request Mar 4, 2024
@miss-islington
[3.12] Consistently spell out *predicate* instead of *pred*. (gh-116308…
0a9356c 
…) (gh-116312)
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@rhettinger @woodruffw
Consistently spell out *predicate* instead of *pred*. (pythongh-116308)
d827f30
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@rhettinger @adorilson
Consistently spell out *predicate* instead of *pred*. (pythongh-116308)
15f78e2
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@rhettinger @diegorusso
Consistently spell out *predicate* instead of *pred*. (pythongh-116308)
b437ac0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Privat33r-dev Privat33r-dev Privat33r-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhettinger @Privat33r-dev