Skip to content

gh-116030: Add ctx argument to ast.Name calls #116031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

gh-116030: Add ctx argument to ast.Name calls #116031

merged 1 commit into from
Feb 28, 2024

Conversation

@Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Feb 28, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 28, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Feb 28, 2024
Privat33r-dev
Privat33r-dev approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Privat33r-dev Privat33r-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JelleZijlstra
JelleZijlstra approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 3b63d07 into python:main Feb 28, 2024
@Eclips4 Eclips4 deleted the issue-116030 branch February 28, 2024 11:16
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Eclips4 @woodruffw
pythongh-116030: test_unparse: Add ctx argument to ast.Name c…
74e1843 
…alls (python#116031)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@Eclips4 @adorilson
pythongh-116030: test_unparse: Add ctx argument to ast.Name c…
18b9075 
…alls (python#116031)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Eclips4 @diegorusso
pythongh-116030: test_unparse: Add ctx argument to ast.Name c…
0221a6d 
…alls (python#116031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

+1 more reviewer

@Privat33r-dev Privat33r-dev Privat33r-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eclips4 @JelleZijlstra @Privat33r-dev