GH-115651: Convert LOAD_MODULE_ATTR into LOAD_INLINE_CONST when the module is itself a constant.
#115711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
requested review from
Fidget-Spinner and
gvanrossum
as code owners
markshannon
commented
Feb 20, 2024
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Generally looks good, just one change requested. Thanks!
gvanrossum
reviewed
Feb 21, 2024
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I have some clarity concerns (based on how long it took me to follow what's happening here) but the basics look good, other than (I think) a missing break.
Fidget-Spinner
approved these changes
Feb 22, 2024
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LGTM I just have a few questions
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…when the module is itself a constant. (pythonGH-115711)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…when the module is itself a constant. (pythonGH-115711)
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…when the module is itself a constant. (pythonGH-115711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module attributes are global variables from other modules. It makes sense to convert them to constants as we already do for global variables.
LOAD_ATTR_MODULEto a constant where the module is already a constant #115651