Skip to content

Conversation

@finite-state-machine
Copy link
Contributor

@finite-state-machine finite-state-machine commented Feb 6, 2024

(The existing documentation suggests there has been some change to the behavior of Flag.__iter__() starting in Python 3.11; this is misleading at best.)

I have no experience with PRs, so please forgive any deficiencies in this submission.

As corrected:
Screenshot 2024-02-06 at 17 04 32


📚 Documentation preview 📚: https://cpython-previews--115107.org.readthedocs.build/

(The existing documentation suggests there has been some change to the
behavior of 'Flag.__iter__()' starting in Python 3.11; this is
misleading at best.)
@ghost
Copy link

ghost commented Feb 6, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, and the PR!

@ethanfurman ethanfurman added 3.11 only security fixes 3.12 only security fixes needs backport to 3.11 only security fixes 3.13 bugs and security fixes needs backport to 3.12 only security fixes labels Feb 7, 2024
@ethanfurman ethanfurman merged commit 3f71c41 into python:main Feb 7, 2024
@miss-islington-app
Copy link

Thanks @finite-state-machine for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2024
…ython 3.11 (pythonGH-115107)

change versionchanged to versionadded
(cherry picked from commit 3f71c41)

Co-authored-by: Finite State Machine <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 7, 2024

GH-115117 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2024
…ython 3.11 (pythonGH-115107)

change versionchanged to versionadded
(cherry picked from commit 3f71c41)

Co-authored-by: Finite State Machine <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 7, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 7, 2024

GH-115118 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 7, 2024
@finite-state-machine finite-state-machine changed the title gh-115106 docs: 'enum.Flag.__iter__()' did not exist prior to Python 3.11 gh-115106 docs: enum.Flag.__iter__() did not exist prior to Python 3.11 Feb 7, 2024
ethanfurman pushed a commit that referenced this pull request Feb 8, 2024
…Python 3.11 (GH-115107) (GH-115118)

change versionchanged to versionadded
(cherry picked from commit 3f71c41)

Co-authored-by: Finite State Machine <[email protected]>
ethanfurman pushed a commit that referenced this pull request Feb 8, 2024
…Python 3.11 (GH-115107) (GH-115117)

change versionchanged to versionadded
(cherry picked from commit 3f71c41)

Co-authored-by: Finite State Machine <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants