Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 27, 2024

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This changes makes sense to me, because
1: We do not see output of the test now.
2: We make sure that right data is written to fd.

Closing #114645 because this approach is better.
Thanks Serhiy.

@serhiy-storchaka serhiy-storchaka merged commit 7a47054 into python:main Jan 27, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_pty-test_spawn_doesnt_hang branch January 27, 2024 16:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2024

GH-114655 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 27, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2024

GH-114656 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 27, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 27, 2024
serhiy-storchaka added a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants