gh-114364: Fix awkward wording about mmap.mmap.seekable being added #114374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
reviewed
Jan 21, 2024
Member
|
@AlexWaygood Can you please take a look? |
Contributor
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
I suggested @ericvsmith's wording from the issue.
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Member
|
I merged Eric and Erland's suggestion and think this good enough. Will automerge and close issue. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…#114374) --------- Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114364. "it requires" is a little unclear and "method return the" is incorrect.