[3.7] closes bpo-35623: Fix integer overflow when sorting large lists (GH-11380) #11401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onGH-11380) There is already a `Py_ssize_t i` defined at function scope that is used for similar loops. By removing the local `int i` declaration that `i` is used, which has the appropriate type. (cherry picked from commit f8b5344) Co-authored-by: sth <[email protected]>
benjaminp
approved these changes
Jan 2, 2019
|
@sth and @benjaminp: Status check is done, and it's a success ✅ . |
|
@sth and @benjaminp: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a
Py_ssize_t idefined at function scope that is usedfor similar loops. By removing the local
int ideclaration thatiisused, which has the appropriate type.
(cherry picked from commit f8b5344)
Co-authored-by: sth [email protected]
https://bugs.python.org/issue35623