Skip to content

bpo-35623: Fix integer overflow when sorting large lists #11380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2019
Merged

bpo-35623: Fix integer overflow when sorting large lists #11380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2025cd
Fix integer overflow when sorting large lists
sth Dec 31, 2018
7ca9e28
Added news
sth Dec 31, 2018
500a97b
Add author to news
serhiy-storchaka Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2018-12-31-02-37-20.bpo-35623.24AQhY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a crash when sorting very long lists. Patch by Stephan Hohe.
1 change: 0 additions & 1 deletion Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2283,7 +2283,6 @@ list_sort_impl(PyListObject *self, PyObject *keyfunc, int reverse)
int ints_are_bounded = 1;

/* Prove that assumption by checking every key. */
int i;
for (i=0; i < saved_ob_size; i++) {

if (keys_are_in_tuples &&
Expand Down