Skip to content

[3.6] bpo-35605: Fix documentation build for sphinx<1.6 #11368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2019
Merged

[3.6] bpo-35605: Fix documentation build for sphinx<1.6 #11368

merged 2 commits into from
Feb 3, 2019

Conversation

@asottile
Copy link
Contributor

@asottile asottile commented Dec 30, 2018 •
edited by bedevere-bot
Loading

@JulienPalard
Copy link
Member

JulienPalard commented Jan 2, 2019

Looks like it still does not work due to #6475

$ pip install 'sphinx<1.6' blurb
$ make htmlhelp
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b htmlhelp -d build/doctrees -D latex_elements.papersize=  . build/htmlhelp 
Running Sphinx v1.5.6

Extension error:
Could not import extension pyspecific (exception: cannot import name 'status_iterator' from 'sphinx.util' (/home/mdk/.venvs/tmp/lib/python3.7/site-packages/sphinx/util/__init__.py))
make: *** [Makefile:45: build] Error 1

@asottile
Copy link
Contributor Author

asottile commented Jan 2, 2019

ah right, deadsnakes has a patch for that too -- I can apply that as well here

@asottile
Copy link
Contributor Author

asottile commented Jan 12, 2019

@JulienPalard friendly ping :) would like another round of review

@ned-deily ned-deily merged commit 9bacdce into python:3.6 Feb 3, 2019
@asottile asottile deleted the sphinx_logging_build_regression branch February 3, 2019 23:23
JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request Mar 18, 2019
@asottile @JulienPalard
[2.7] bpo-35605: Fix documentation build for sphinx<1.6 (pythonGH-11368)
ccb202f 
(cherry picked from commit dfc8fc15fa989acba3c372572e52bbcb5ab38a37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@asottile @JulienPalard @eamanu @ned-deily @the-knights-who-say-ni @bedevere-bot