gh-113560: Improve docs for set.issubset and set.issuperset
#113562
Conversation
Objects/setobject.c
Outdated
| "issubset($self, /, other)\n\ | ||
| --\n\ | ||
| \n\ | ||
| Return True if all elements in this set are found in other(iterable)."); |
There was a problem hiding this comment.
Why do you use other() as a callable?
| Return True if all elements in this set are found in other(iterable)."); | |
| Return True if all elements in this set are found in other iterable."); |
There was a problem hiding this comment.
Why do you use
other()as a callable?
I just want to explain that the parameter other is an iterable :) Perhaps it would be better to replace other with iterable? 🤔
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
The documentation in Doc/library/stdtypes.rst is short enough to be used as a docstring.
Thanks. This change looks good. updated! :) |
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @CharlieZhao95 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @CharlieZhao95 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…rset() (pythonGH-113562) (cherry picked from commit 11c5822) Co-authored-by: Charlie Zhao <[email protected]>
…rset() (pythonGH-113562) (cherry picked from commit 11c5822) Co-authored-by: Charlie Zhao <[email protected]>
|
GH-114643 is a backport of this pull request to the 3.11 branch. |
|
GH-114644 is a backport of this pull request to the 3.12 branch. |
…erset() (GH-113562) (GH-114643) (cherry picked from commit 11c5822) Co-authored-by: Charlie Zhao <[email protected]>
…erset() (GH-113562) (GH-114644) (cherry picked from commit 11c5822) Co-authored-by: Charlie Zhao <[email protected]>
4 participants
help(set.issubset)does not tell the truth that it could accept any iterable as an argument #113560