Skip to content

gh-113078: Use uint64 for dev_t and uint32 for makedev params #113080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-113078: Use uint64 for dev_t and uint32 for makedev params #113080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ac7e05
gh-113078: Use uint64 for dev_t and uint32 for makedev params
renatoalencar Dec 14, 2023
51d5f46
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-12-14-01-46-24.gh-issue-113078.FQ5--F.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix POSIX's stat and makedev issue on FreeBSD when using a ZFS filesystem
14 changes: 6 additions & 8 deletions Modules/clinic/posixmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@ _Py_Gid_Converter(PyObject *obj, gid_t *p)
#endif /* MS_WINDOWS */


#define _PyLong_FromDev PyLong_FromLongLong
#define _PyLong_FromDev PyLong_FromUnsignedLongLong


#if (defined(HAVE_MKNOD) && defined(HAVE_MAKEDEV)) || defined(HAVE_DEVICE_MACROS)
Expand Down Expand Up @@ -12040,16 +12040,16 @@ os_minor_impl(PyObject *module, dev_t device)
/*[clinic input]
os.makedev -> dev_t

major: int
minor: int
major: unsigned_int
minor: unsigned_int
/

Composes a raw device number from the major and minor device numbers.
[clinic start generated code]*/

static dev_t
os_makedev_impl(PyObject *module, int major, int minor)
/*[clinic end generated code: output=881aaa4aba6f6a52 input=4b9fd8fc73cbe48f]*/
os_makedev_impl(PyObject *module, unsigned int major, unsigned int minor)
/*[clinic end generated code: output=19d6d22807bf0d20 input=27d2f0106009da11]*/
{
return makedev(major, minor);
}
Expand Down