gh-112998: zipfile: fix extractall makedirs race condition #112966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
pbsds
changed the title
pbsds
force-pushed
the
fix-zipfile-makedirs
branch
3 times, most recently
from
dc3f81e to
ca20b8e
Compare
pbsds
force-pushed
the
fix-zipfile-makedirs
branch
from
ca20b8e to
5e81a45
Compare
Comment on lines
1787
to
+1791
| if not os.path.isdir(targetpath): | ||
| os.mkdir(targetpath) | ||
| try: | ||
| os.mkdir(targetpath) | ||
| except FileExistsError: | ||
| pass |
Member
There was a problem hiding this comment.
Currently it raises FileExistsError if targetpath exists, but is not a directory. With this change it will be silent. It is not good, because it is an error.
Please add a test for extracting a directory in place of existing regular file.
Member
There was a problem hiding this comment.
Such test was added in #114960, and it fails with this PR.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix it
zipfileextractall is not multi-threading safe #112998