Skip to content

gh-111800: Fix test_recursive_repr from test_io under WASI #112150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2023
Merged

gh-111800: Fix test_recursive_repr from test_io under WASI #112150

merged 2 commits into from
Nov 16, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 16, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Nov 16, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 16, 2023
Closed
@brettcannon brettcannon self-assigned this Nov 16, 2023
@brettcannon
Copy link
Member

brettcannon commented Nov 16, 2023

I'm going to test the change locally on my pydebug build, then I'll merge.

brettcannon
brettcannon requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out there are two instances of test_recursive_repr(); second one is at line 2804.

@bedevere-app
Copy link

bedevere-app bot commented Nov 16, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brettcannon brettcannon merged commit 974847b into python:main Nov 16, 2023
@brettcannon
Copy link
Member

brettcannon commented Nov 16, 2023

Thanks!

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-111800: Fix test_recursive_repr from test_io under WASI …
4c4f7c6 
…to not recurse so deeply (pythonGH-112150)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-111800: Fix test_recursive_repr from test_io under WASI …
eb20952 
…to not recurse so deeply (pythonGH-112150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@kushaldas kushaldas Awaiting requested review from kushaldas

Assignees

@brettcannon brettcannon

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @brettcannon