gh-107149: make new opcode util functions private rather than public and unstable #112042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
interpreter-core
vstinner
reviewed
Nov 13, 2023
Member
Since functions are new in Python 3.13, there is no need to document these changes. |
arhadthedev
reviewed
Nov 13, 2023
Co-authored-by: Oleg Iarygin <[email protected]>
iritkatriel
commented
Nov 13, 2023
vstinner
approved these changes
Nov 13, 2023
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Thanks for moving definitions to pycore_compile.h.
Member
|
Thanks @iritkatriel. It's better to keep the API private for now, and only consider making it public if we have a clear user request to make it public (even if it's as an "unstable" API). |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ublic and unstable (python#112042)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ublic and unstable (python#112042)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.