gh-111729: update generic syntax for typing.Concatenate sample code in Doc/library/typing.rst
#111734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CubeSugarCheese
requested review from
AlexWaygood,
JelleZijlstra and
gvanrossum
as code owners
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
sobolevn
reviewed
Nov 4, 2023
Member
There was a problem hiding this comment.
I know that other examples already do this, but in my opinion the current example is better, because it is more portable. 3.12 is out for like 2 months, while other versions do not support this syntax.
However, since we already did this change, I agree that all examples should be consistent.
Thanks a lot! :)
|
Thanks @CubeSugarCheese for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 7, 2023
…e code in `Doc/library/typing.rst` (pythonGH-111734) use new generic syntax (cherry picked from commit c3e19c3) Co-authored-by: 方糖 <[email protected]>
|
GH-111814 is a backport of this pull request to the 3.12 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Nov 7, 2023
…le code in `Doc/library/typing.rst` (GH-111734) (#111814) (cherry picked from commit c3e19c3) Co-authored-by: 方糖 <[email protected]>
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 8, 2023
…e code in `Doc/library/typing.rst` (python#111734) use new generic syntax
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…e code in `Doc/library/typing.rst` (python#111734) use new generic syntax
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…e code in `Doc/library/typing.rst` (python#111734) use new generic syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #111729
📚 Documentation preview 📚: https://cpython-previews--111734.org.readthedocs.build/